Skip to content

Fix token creation in namespace - #31288

Closed
rculpepper wants to merge 4 commits into
mainfrom
rculpepper/vault-36277
Closed

Fix token creation in namespace#31288
rculpepper wants to merge 4 commits into
mainfrom
rculpepper/vault-36277

Conversation

@rculpepper

@rculpepper rculpepper commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Description

This PR changes the system view used for token creation so that namespace TTL configuration is used for the token TTL without being restricted by the root namespace configuration.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@rculpepper
rculpepper requested a review from a team as a code owner July 15, 2025 21:48
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 15, 2025
@github-actions

github-actions Bot commented Jul 15, 2025

Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@github-actions

github-actions Bot commented Jul 15, 2025

Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@vercel

vercel Bot commented Aug 11, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vault-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2025 4:40pm

@victorr victorr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants